From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Fri, 1 Sep 2006 21:35:14 +0000 (+0000)
Subject: removed try-catch in favor of cleaner code
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=7bf3bf914001d505bca501809fdc147dbfd71803;p=evergreen%2Fpines.git

removed try-catch in favor of cleaner code


git-svn-id: svn://svn.open-ils.org/ILS/trunk@5850 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Circ/Money.pm b/Open-ILS/src/perlmods/OpenILS/Application/Circ/Money.pm
index 60ed9982a0..a41b892fad 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Circ/Money.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Circ/Money.pm
@@ -244,6 +244,7 @@ sub retrieve_payments {
 }
 
 
+
 __PACKAGE__->register_method(
 	method	=> "retrieve_payments2",
 	api_name	=> "open-ils.circ.money.payment.retrieve.all",
@@ -264,9 +265,8 @@ sub retrieve_payments2 {
 		my $meth = "retrieve_money_$type";
 		my $p = $e->$meth($_->id) or return $e->event;
 		$p->payment_type($type);
-		try {
-			$p->cash_drawer($e->retrieve_actor_workstation($p->cash_drawer));
-		} catch Error with {};
+		$p->cash_drawer($e->retrieve_actor_workstation($p->cash_drawer))
+			if $p->has_field('cash_drawer');
 		push( @payments, $p );
 	}