From: miker <miker@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Thu, 27 Mar 2008 03:54:35 +0000 (+0000)
Subject: The advanced query syntax parser here was cribbed from the original implemenation... 
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=7c3e992328a7f9eb474baeb8ff4e93175a2b29c2;p=Evergreen.git

The advanced query syntax parser here was cribbed from the original implemenation inside the OpenSearch server.  mod_perl, due to being too clever by half, required a call to decode_utf8 to shove raw octets into the correct shape.  Becuase the data coming to this implementation comes from opensrf, which is unicode end-to-end via JSON, it's somebody else's job to make sure the characters are properly encoded, and once they get to us they're already proper UTF-8 character strings.  Thus, no need for (and things broken by) the call to decode_utf8.

Why is that explanation so long?  So that we don't do it again ... :)



git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_2@9143 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm b/Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm
index a09cbe50cc..9f66cdee27 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Search/Biblio.pm
@@ -450,7 +450,6 @@ sub multiclass_query {
     $logger->debug("initial search query => $query");
     my $orig_query = $query;
 
-    $query = decode_utf8($query);
     $query =~ s/\+/ /go;
     $query =~ s/'//go;
     $query =~ s/^\s+//go;