From: Cesar Velez <cesar.velez@equinoxinitiative.org>
Date: Mon, 26 Jun 2017 16:25:06 +0000 (-0400)
Subject: LP#1669907: Web Staff Bib record Holds View dups
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=7c55d3d1934dca110c1710c3f5ca67012789a61c;p=evergreen%2Fjoelewis.git

LP#1669907: Web Staff Bib record Holds View dups

In the webstaff client, switching from the View Holds tab
to the OPAC View and back would result in the list of hold
requests getting duplicated.

This patch fixes the problem.

Caching of tab data is explicitly not being done ATM,
so this takes care of the issue for now.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
index c8471a9c8d..17eb562da1 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
@@ -1513,6 +1513,7 @@ function($scope , $routeParams , $location , $window , $q , egCore , egHolds , e
             {pickup_lib : egCore.org.descendants($scope.pickup_ou.id(), true)}
         ).then(
             function(hold_data) {
+                hold_ids = []; // clear the list of ids, hack to avoid dups
                 angular.forEach(hold_data, function(list, type) {
                     hold_ids = hold_ids.concat(list);
                 });