From: Thomas Berezansky <tsbere@mvlc.org>
Date: Tue, 1 Oct 2013 18:48:06 +0000 (-0400)
Subject: Proper substr usage in "since" mode
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=7db5287a7d54e35d304e12804bf5dfe67ef0a393;p=working%2FEvergreen.git

Proper substr usage in "since" mode

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
---

diff --git a/Open-ILS/src/support-scripts/Marque.pm.in b/Open-ILS/src/support-scripts/Marque.pm.in
index 89be63207d..df0bd7c337 100644
--- a/Open-ILS/src/support-scripts/Marque.pm.in
+++ b/Open-ILS/src/support-scripts/Marque.pm.in
@@ -445,7 +445,7 @@ sub next {
             if ($Marque::config->option_value('since')) {
                 my $leader = $r->leader();
                 if ($U->is_true($bre->deleted())) {
-                    $leader = substr($leader, 5, 1, 'd');
+                    substr($leader, 5, 1) = 'd';
                     $r->leader($leader);
                 } else {
                     my $create_date = Date::Manip::Date->new;
@@ -453,10 +453,10 @@ sub next {
                     my $edit_date = Date::Manip::Date->new;
                     $edit_date->parse($bre->edit_date());
                     if ($self->{since_date}->cmp($create_date) < 0) {
-                        $leader = substr($leader, 5, 1, 'n');
+                        substr($leader, 5, 1) = 'n';
                         $r->leader($leader);
                     } elsif ($self->{since_date}->cmp($edit_date) < 0) {
-                        $leader = substr($leader, 5, 1, 'c');
+                        substr($leader, 5, 1) = 'c';
                         $r->leader($leader);
                     }
                 }
@@ -689,7 +689,7 @@ sub next {
             if ($Marque::config->option_value('since')) {
                 my $leader = $r->leader();
                 if ($U->is_true($are->deleted())) {
-                    $leader = substr($leader, 5, 1, 'd');
+                    substr($leader, 5, 1) = 'd';
                     $r->leader($leader);
                 } else {
                     my $create_date = Date::Manip::Date->new;
@@ -697,10 +697,10 @@ sub next {
                     my $edit_date = Date::Manip::Date->new;
                     $edit_date->parse($are->edit_date());
                     if ($self->{since_date}->cmp($create_date) < 0) {
-                        $leader = substr($leader, 5, 1, 'n');
+                        substr($leader, 5, 1) = 'n';
                         $r->leader($leader);
                     } elsif ($self->{since_date}->cmp($edit_date) < 0) {
-                        $leader = substr($leader, 5, 1, 'c');
+                        substr($leader, 5, 1) = 'c';
                         $r->leader($leader);
                     }
                 }