From: Mike Rylander <mrylander@gmail.com>
Date: Fri, 20 May 2011 13:18:05 +0000 (-0400)
Subject: Revert "When placing holds on a bib with monographic part, require selection of a... 
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=7eed24efc3ac0ffc7269002c76f5b6509903498f;p=working%2FEvergreen.git

Revert "When placing holds on a bib with monographic part, require selection of a specific part"

This reverts commit 69395e8c55db3a0993b2a48eb930ab55402d5c8d.

We must not force P-type holds as not all copies may not use parts.  Imagine a situation where
only one library breaks up a season of Seinfeld by using a part per DVD, and all others leave
them bound and therefore need no part designations.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/web/opac/locale/en-US/opac.dtd b/Open-ILS/web/opac/locale/en-US/opac.dtd
index 7a41e07a0e..b52813aee7 100644
--- a/Open-ILS/web/opac/locale/en-US/opac.dtd
+++ b/Open-ILS/web/opac/locale/en-US/opac.dtd
@@ -609,7 +609,6 @@ We recommend that you remove this title from any bookbags it may have been added
 <!ENTITY common.hold.issuance "Issuance Hold">
 <!ENTITY common.hold.advanced "Advanced Hold Options">
 <!ENTITY common.hold.delivery "Please select a physical location where your hold can be delivered.">
-<!ENTITY common.hold.part_required "Please select a specific monographic part to hold.">
 <!ENTITY common.hold.checked_out "This item is already checked out.">
 <!ENTITY common.hold.checked_out.override "This item is already checked out.  Would you like to place the hold anyway?">
 <!ENTITY common.hold.exists "A hold already exists on the requested item.">
diff --git a/Open-ILS/web/opac/skin/default/js/holds.js b/Open-ILS/web/opac/skin/default/js/holds.js
index 2be3c39824..73514c1243 100644
--- a/Open-ILS/web/opac/skin/default/js/holds.js
+++ b/Open-ILS/web/opac/skin/default/js/holds.js
@@ -928,15 +928,10 @@ function holdsBuildHoldFromWindow() {
 	else
 		hold.email_notify(0);
 
-    if(holdArgs.recordParts && holdArgs.recordParts.length) {
-        var part = getSelectorVal($('holds_parts_selector'));
-        if(part) {
-            holdArgs.type = 'P';
-            holdArgs.part = part;
-        } else {
-            alertId('holds_pick_part');
-            return;
-        }
+    var part = getSelectorVal($('holds_parts_selector'));
+    if(part) {
+        holdArgs.type = 'P';
+        holdArgs.part = part;
     }
 
 	var target = holdArgs[holdTargetTypeMap[holdArgs.type]];
diff --git a/Open-ILS/web/opac/skin/default/xml/common/holds.xml b/Open-ILS/web/opac/skin/default/xml/common/holds.xml
index 014ee2482a..7d8712d235 100644
--- a/Open-ILS/web/opac/skin/default/xml/common/holds.xml
+++ b/Open-ILS/web/opac/skin/default/xml/common/holds.xml
@@ -234,7 +234,6 @@
 	<span class='hide_me' id='holds_explain_adv'>&holds.advanced_options;</span>
 
 	<span class='hide_me' id='holds_pick_good_org'>&common.hold.delivery;</span>
-	<span class='hide_me' id='holds_pick_part'>&common.hold.part_required;</span>
 
 	<span class='hide_me' id='hold_dup_exists'>&common.hold.exists;</span>
 	<span class='hide_me' id='hold_checked_out'>&common.hold.checked_out;</span>