From: Steven Callender Date: Tue, 19 Mar 2019 16:57:55 +0000 (-0400) Subject: LP#1819540 - Change expire list to match what the hold expire function X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=7f48513889098e47ee4a9d1b7cdbf5d5fe2ca8bb;p=working%2FEvergreen.git LP#1819540 - Change expire list to match what the hold expire function Updated to use 'today'::timestamptz as suggested by Mike Rylander. Testing: 1. Update a few holds that show up on the hold shelf so their shelf time is set to now. 2. Confirm that you see them on the holds shelf. 3. Show clearable holds, holds are on the list. 4. Check in one of the items, and see that it goes back on the hold shelf. After Fix Applies. 1. Update a few holds that show up on the hold shelf so their shelf time is set to now. 2. Confirm that you see them on the holds shelf. 3. Show clearable holds, holds are no longer on the list. Signed-off-by: Steven Callender Signed-off-by: Josh Stompro Signed-off-by: John Amundson Signed-off-by: Jason Stephenson --- diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm index 2a5c87e9b4..6c69acb937 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm @@ -2177,7 +2177,7 @@ SELECT h.id, h.request_time, h.capture_time, h.fulfillment_time, h.checkin_time ELSE 4 END AS hold_status, - (h.shelf_expire_time < NOW() OR h.cancel_time IS NOT NULL OR (h.current_shelf_lib IS NOT NULL AND h.current_shelf_lib <> h.pickup_lib)) AS clear_me, + (h.shelf_expire_time < 'today'::timestamptz OR h.cancel_time IS NOT NULL OR (h.current_shelf_lib IS NOT NULL AND h.current_shelf_lib <> h.pickup_lib)) AS clear_me, (h.usr <> h.requestor) AS is_staff_hold,