From: Bill Erickson <berick@esilibrary.com>
Date: Thu, 10 Apr 2014 20:49:36 +0000 (-0400)
Subject: LP#1301599 TPAC replace aria-label with title
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=7f7ed3c9f027ae2fe52f767270f9f1aa2aedff1f;p=evergreen%2Fpines.git

LP#1301599 TPAC replace aria-label with title

As appropriate, replace aria-label attributes with traditional HTML
title attributes.

For ref, from the LP entry:

http://www.w3.org/TR/2013/WD-aria-in-html-20131003/#first-rule-of-aria-use

"If you can use a native HTML element [HTML5] or attribute with the
semantics and behaviour you require already built in, instead of
re-purposing an element and adding an ARIA role, state or property to
make it accessible, then do so."

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/src/templates/opac/myopac/holds.tt2 b/Open-ILS/src/templates/opac/myopac/holds.tt2
index 8d049eaf17..de5fcbdc27 100644
--- a/Open-ILS/src/templates/opac/myopac/holds.tt2
+++ b/Open-ILS/src/templates/opac/myopac/holds.tt2
@@ -59,7 +59,7 @@
             <tr>
                 <td>
                     <select name="action" id="acct_holds_actions" 
-                      aria-label="[% l('Select your action for the selected holds') %]"
+                      title="[% l('Select your action for the selected holds') %]"
                       title="[% l('Select your action for the selected holds') %]">
                         <option id='myopac_holds_actions_none' value=''>
                         -- [% l("Actions for selected holds") %] --
diff --git a/Open-ILS/src/templates/opac/parts/advanced/search.tt2 b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
index f60d499d7a..52427338ec 100644
--- a/Open-ILS/src/templates/opac/parts/advanced/search.tt2
+++ b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
@@ -121,7 +121,7 @@
 
                 [% CASE "copy_location" %]
                     <select id="adv_copy_location_selector" 
-                        aria-label="[% l('Select Shelving Location') %]"
+                        title="[% l('Select Shelving Location') %]"
                         name="fi:locations" size="3" multiple="multiple">
                     </select>
                 [% 
diff --git a/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2 b/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2
index 3c242f2be0..c8eb62e71c 100644
--- a/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2
@@ -19,7 +19,7 @@
 <select id='[% id %]' name='[% name %]'[%
     multiple ? ' multiple="multiple"' : '';
     size ? (' size="' _ size _ '"') : '';
-%] aria-label="[% filter_label || l('Select item type:') %]">
+%] title="[% filter_label || l('Select item type:') %]">
 [% IF none_ok %]
     <option value=''>[% none_label ? none_label : l('-- Any --') %]</option>
 [% END;
diff --git a/Open-ILS/src/templates/opac/parts/myopac/base.tt2 b/Open-ILS/src/templates/opac/parts/myopac/base.tt2
index 6fd5c9ce23..dfc7abff71 100644
--- a/Open-ILS/src/templates/opac/parts/myopac/base.tt2
+++ b/Open-ILS/src/templates/opac/parts/myopac/base.tt2
@@ -34,7 +34,6 @@
                <form name="acct_nav">
 
                  <select name="acct_url" 
-                    aria-label="[% l('Select an account page') %]" 
                     title="[% l('Select an account page') %]" 
                     onchange="window.location.href=document.acct_nav.acct_url.options[document.acct_nav.acct_url.selectedIndex].value">
                     <option value="" selected="selected">[% l('Go to...') %]</option>
diff --git a/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2 b/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
index cf38a6270a..a9e52b7f6d 100644
--- a/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
+++ b/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
@@ -41,7 +41,7 @@
         <form name="acct_prefs_nav">
             <select name="acct_prefs_url" 
               [% select_title = l('Select a preference page') %]
-              aria-label="[% select_title %]" title="[% select_title %]"
+              title="[% select_title %]" title="[% select_title %]"
               onchange="window.location.href=document.acct_prefs_nav.acct_prefs_url.options[document.acct_prefs_nav.acct_prefs_url.selectedIndex].value">
         [% FOREACH page IN acct_prefs_pages;
             IF page.url != prefs_page; -%]
diff --git a/Open-ILS/src/templates/opac/parts/org_selector.tt2 b/Open-ILS/src/templates/opac/parts/org_selector.tt2
index 1b608557d8..ab4d7c91f0 100644
--- a/Open-ILS/src/templates/opac/parts/org_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/org_selector.tt2
@@ -28,8 +28,7 @@ BLOCK build_org_selector;
     -%]
 
     <select [% IF id %] id='[% id %]' [% END -%]
-            [% IF arialabel %] aria-label='[% arialabel %]' 
-            [% ELSE %] title='[% l("Select Library") %]' [% END -%]
+            title='[% arialabel || l("Select Library") %]' 
             name='[% name %]'>
     [%- 
         WHILE node_stack.size > 0; 
diff --git a/Open-ILS/src/templates/opac/parts/qtype_selector.tt2 b/Open-ILS/src/templates/opac/parts/qtype_selector.tt2
index 6986fc12d9..1c8fc2cddf 100644
--- a/Open-ILS/src/templates/opac/parts/qtype_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/qtype_selector.tt2
@@ -8,7 +8,7 @@
     {value => "id|bibcn", label => l("Bib Call Number")}
 ] %]
 <select name="[% name || 'qtype' %]"[% IF id; ' id="'; id ; '"' ; END -%]
-    aria-label="[% l('Select query type:') %]">
+    title="[% l('Select query type:') %]">
     [%  query_type = query_type || CGI.param('qtype') || search.default_qtypes.0;
       FOR qt IN query_types;
         NEXT IF browse_only AND NOT qt.browse -%]