From: Jason Boyer <jboyer@library.in.gov>
Date: Thu, 24 Aug 2017 21:34:02 +0000 (-0400)
Subject: LP1712922: Exclude Deleted ACPL in Vol/Copy Editor
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=81b26198f1ad2c79c0cb872c05892dc1f3ce0030;p=Evergreen.git

LP1712922: Exclude Deleted ACPL in Vol/Copy Editor

Just what it says on the tin. When loading the list of ACPL
in the editor only retrieve the non-deleted locations.

Tester's note: there's no database contraint that strictly
prevents a copy from linking to a deleted location, so for
items like that, the copy location selector will be blank. This
is an uncommon situation, but Evergreen admins can identify
such items by running the following query:

select acp.id, acp.barcode, acpl.name
from asset.copy acp
join asset.copy_location acpl on (acpl.id = acp.location)
where not acp.deleted
and acpl.deleted
order by acp.id;

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index cce204c323..f2a6268a98 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -138,7 +138,7 @@ function(egCore , $q) {
 
     service.get_locations = function(orgs) {
         return egCore.pcrud.search('acpl',
-            {owning_lib : orgs},
+            {owning_lib : orgs, deleted : 'f'},
             {order_by : { acpl : 'name' }}, {atomic : true}
         );
     };