From: dbs <dbs@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Mon, 25 May 2009 03:48:24 +0000 (+0000)
Subject: Intended defence against lack of caption was still failing; keep it simple, dbs
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=8278937d2ab16092991b7b3c04d57decdc9eb02a;p=Evergreen.git

Intended defence against lack of caption was still failing; keep it simple, dbs


git-svn-id: svn://svn.open-ils.org/ILS/trunk@13223 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Holding.pm b/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Holding.pm
index 1c2048538d..ab63812922 100755
--- a/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Holding.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Holding.pm
@@ -238,7 +238,7 @@ sub validate {
     my $self = shift;
 
     foreach my $key (keys %{$self->{_mfhdh_SUBFIELDS}}) {
-	if (!($self->{_mfhdh_CAPTION}) && $self->{_mfhdh_CAPTION}->capfield($key)) {
+	if (!$self->{_mfhdh_CAPTION} || !$self->{_mfhdh_CAPTION}->capfield($key)) {
 	    return 0;
 	}
     }