From: Dan Scott <dscott@laurentian.ca>
Date: Fri, 16 Sep 2016 17:49:01 +0000 (-0400)
Subject: LP#1624491 Avoid uninit var prox_cache during holds processing
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=82b16fc7bb93d31cfa9ff30c0614139666bafaf3;p=evergreen%2Ftadl.git

LP#1624491 Avoid uninit var prox_cache during holds processing

open-ils.circ was logging a prox_cache hash value before it is
guaranteed to have been initialized. Instead, log messages _after_ they
have been initialized.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index 021d3bb954..5d08462027 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -2617,12 +2617,11 @@ sub _check_title_hold_is_possible {
     my $home_org = $patron->home_ou;
     my $req_org = $request_lib->id;
 
-    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
-
     $prox_cache{$home_org} =
         $e->search_actor_org_unit_proximity({from_org => $home_org})
         unless $prox_cache{$home_org};
     my $home_prox = $prox_cache{$home_org};
+    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
 
     my %buckets;
     my %hash = map { ($_->to_org => $_->prox) } @$home_prox;
@@ -2750,12 +2749,11 @@ sub _check_issuance_hold_is_possible {
     my $home_org = $patron->home_ou;
     my $req_org = $request_lib->id;
 
-    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
-
     $prox_cache{$home_org} =
         $e->search_actor_org_unit_proximity({from_org => $home_org})
         unless $prox_cache{$home_org};
     my $home_prox = $prox_cache{$home_org};
+    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
 
     my %buckets;
     my %hash = map { ($_->to_org => $_->prox) } @$home_prox;
@@ -2891,12 +2889,11 @@ sub _check_monopart_hold_is_possible {
     my $home_org = $patron->home_ou;
     my $req_org = $request_lib->id;
 
-    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
-
     $prox_cache{$home_org} =
         $e->search_actor_org_unit_proximity({from_org => $home_org})
         unless $prox_cache{$home_org};
     my $home_prox = $prox_cache{$home_org};
+    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
 
     my %buckets;
     my %hash = map { ($_->to_org => $_->prox) } @$home_prox;