From: Jason Boyer <JBoyer@equinoxinitiative.org>
Date: Tue, 15 Sep 2020 13:00:15 +0000 (-0400)
Subject: LP1895660: SuperCat.pm
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=844b2da1c38d045c45892bf07bdeab5a88d8418c;p=evergreen%2Fpines.git

LP1895660: SuperCat.pm

"my" variable $U masks earlier declaration in same scope

AppUtils is 'use'-ed and assigned to $U at the top of the file
and shared among the rest of the modules already.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
index 2715571e19..edaa48cb6e 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm
@@ -3797,9 +3797,6 @@ sub as_xml {
 package OpenILS::Application::SuperCat::unAPI::acp;
 use base qw/OpenILS::Application::SuperCat::unAPI/;
 
-use OpenILS::Application::AppUtils;
-my $U = "OpenILS::Application::AppUtils";
-
 sub as_xml {
     my $self = shift;
     my $args = shift;