From: Bill Erickson <berickxx@gmail.com>
Date: Thu, 16 Jun 2016 18:10:39 +0000 (-0400)
Subject: hold targeter reify experiment
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=87586be4bf2ca62ed23d166b542377b2b15bdb2c;p=working%2FEvergreen.git

hold targeter reify experiment

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm b/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
index 4a29a077eb..d592593d8f 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
@@ -288,6 +288,7 @@ sub copy_prox_map {
 
 # Captures the exit message, rolls back the cstore transaction/connection,
 # and returns false.
+# is_error : log the final message and editor event at ERR level.
 sub exit_targeter {
     my ($self, $msg, $is_error) = @_;
 
@@ -1052,7 +1053,7 @@ sub target {
     my $hold = $e->retrieve_action_hold_request($hold_id)
         or return $self->exit_targeter("No hold found", 1);
 
-    return $self->exit_targeter("Hold is not eligible for targeting", 1)
+    return $self->exit_targeter("Hold is not eligible for targeting")
         if $hold->capture_time     || 
            $hold->cancel_time      || 
            $hold->fulfillment_time ||