From: Jason Stephenson <jason@sigio.com>
Date: Thu, 29 Jan 2015 12:59:07 +0000 (-0500)
Subject: LP#1415898 Fix Potential Cstore Starvation in KPAC
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=87b2ffd1cae21d34b41eaef12696572177d9b046;p=evergreen%2Ftadl.git

LP#1415898 Fix Potential Cstore Starvation in KPAC

The getit_results function in EGKPacLoader.pm does xact_begin, which
opens a connected session to a cstore drone.  It later does xact_rollback,
which does not disconnect the session.  This leaves a drone hanging for
several seconds unable to responde to new requests.  This commit switches
to a rollback call that does disconnect the session.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm
index 0598947b62..32e394b594 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm
@@ -222,7 +222,7 @@ sub load_getit_results {
     } else { 
         $e->xact_begin;
         $ctx->{hold} = $e->retrieve_action_hold_request($hold_id);
-        $e->xact_rollback;
+        $e->rollback;
     }
 
     return Apache2::Const::OK;