From: phasefx <phasefx@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Mon, 18 Oct 2010 17:44:59 +0000 (+0000)
Subject: stop sign page was incorrectly coming up for all penalties
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=87f38a32caf555fb72a8023109e35afae2d0a866;p=evergreen%2Ftadl.git

stop sign page was incorrectly coming up for all penalties


git-svn-id: svn://svn.open-ils.org/ILS/trunk@18380 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/xul/staff_client/server/patron/display.js b/Open-ILS/xul/staff_client/server/patron/display.js
index dcb398bdfe..01804d7fa0 100644
--- a/Open-ILS/xul/staff_client/server/patron/display.js
+++ b/Open-ILS/xul/staff_client/server/patron/display.js
@@ -932,9 +932,13 @@ patron.display.prototype = {
                     }
                 }
                 var penalties = obj.patron.standing_penalties();
-                if (penalties.length > 0) { msg += '<dl>'; }
+                var dl_flag_opened = false;
                 for (var i = 0; i < penalties.length; i++) {
                     if (penalties[i].standing_penalty().block_list() || penalties[i].standing_penalty().id() == 20 /* ALERT_NOTE */) {
+                        if (!dl_flag_opened) {
+                            msg += '<dl>';
+                            dl_flag_opened = true;
+                        }
                         msg += '<dt>';
                         msg += obj.OpenILS.data.hash.aou[ penalties[i].org_unit() ].shortname() + ' : ' + penalties[i].standing_penalty().label() + '<br/>';
                         msg += '</dt><dd>';
@@ -942,7 +946,7 @@ patron.display.prototype = {
                         msg += '</dd>';
                     }
                 }
-                if (penalties.length > 0) { msg += '</dl>'; }
+                if (dl_flag_opened) { msg += '</dl>'; }
                 var holds = params.holds_summary;
                 if (holds.ready && holds.ready > 0) {
                     msg += $("patronStrings").getFormattedString('staff.patron.display.init.holds_ready', [holds.ready]);