From: Jane Sandberg <sandbej@linnbenton.edu>
Date: Wed, 9 Oct 2019 18:42:08 +0000 (-0700)
Subject: LP1816475: use [routerLink] instead of href in Angular app
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=8a06a52969559e7de5fb0daeec0746250b4c3a4b;p=evergreen%2Fpines.git

LP1816475: use [routerLink] instead of href in Angular app

Using <a href=""> forces a reload of the Angular app in the user's
browser, which substantially slows down the experience.  This commit
changes some href attributes to routerLink directives in the booking
navigation menu.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/eg2/src/app/staff/nav.component.html b/Open-ILS/src/eg2/src/app/staff/nav.component.html
index d682541afb..265368a62a 100644
--- a/Open-ILS/src/eg2/src/app/staff/nav.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/nav.component.html
@@ -310,11 +310,11 @@
           Booking
         </a>
         <div class="dropdown-menu" ngbDropdownMenu>
-          <a class="dropdown-item" href="staff/booking/create_reservation">
+          <a class="dropdown-item" routerLink="/staff/booking/create_reservation">
             <span class="material-icons">add</span>
             <span i18n>Create Reservations</span>
           </a>
-          <a class="dropdown-item" href="staff/booking/pull_list">
+          <a class="dropdown-item" routerLink="/staff/booking/pull_list">
             <span class="material-icons">list</span>
             <span i18n>Pull List</span>
           </a>
@@ -322,15 +322,15 @@
             <span class="material-icons">pin_drop</span>
             <span i18n>Capture Resources</span>
           </a>
-          <a class="dropdown-item" href="staff/booking/pickup">
+          <a class="dropdown-item" routerLink="/staff/booking/pickup">
             <span class="material-icons">trending_up</span>
             <span i18n>Pick Up Reservations</span>
           </a>
-          <a class="dropdown-item" href="staff/booking/return">
+          <a class="dropdown-item" routerLink="/staff/booking/return">
             <span class="material-icons">trending_down</span>
             <span i18n>Return Reservations</span>
           </a>
-          <a class="dropdown-item" href="staff/booking/manage_reservations">
+          <a class="dropdown-item" routerLink="/staff/booking/manage_reservations">
             <span class="material-icons">layers</span>
             <span i18n>Manage Reservations</span>
           </a>