From: Bill Erickson <berickxx@gmail.com>
Date: Tue, 26 Mar 2019 15:23:22 +0000 (-0400)
Subject: LP1821382 Grid scroll menu repairs
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=8bd4c6aea7379b446d213af78ad649bc949f7abf;p=working%2FEvergreen.git

LP1821382 Grid scroll menu repairs

Make scrollable menus require addition of a class so the CSS does not
apply to all drop-down menus.  Specifically, it makes less sense to use
scrollable menus for the main menu bar.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/eg2/src/app/share/grid/grid-toolbar.component.html b/Open-ILS/src/eg2/src/app/share/grid/grid-toolbar.component.html
index 6baa505979..b5408abc5d 100644
--- a/Open-ILS/src/eg2/src/app/share/grid/grid-toolbar.component.html
+++ b/Open-ILS/src/eg2/src/app/share/grid/grid-toolbar.component.html
@@ -35,7 +35,7 @@
       <span title="Actions For Selected Rows" i18n-title
         class="material-icons mat-icon-in-button">playlist_add_check</span>
     </button>
-    <div class="dropdown-menu" ngbDropdownMenu>
+    <div class="dropdown-menu scrollable-menu" ngbDropdownMenu>
       <button class="dropdown-item" (click)="performAction(action)"
         *ngFor="let action of gridContext.toolbarActions"
         [disabled]="shouldDisableAction(action)">
@@ -106,7 +106,7 @@
       <span title="Show Grid Options" i18n-title
         class="material-icons mat-icon-in-button">settings</span>
     </button>
-    <div class="dropdown-menu" ngbDropdownMenu>
+    <div class="dropdown-menu scrollable-menu" ngbDropdownMenu>
       <a class="dropdown-item label-with-material-icon"
         (click)="columnConfDialog.open({size:'lg'})">
         <span class="material-icons">build</span>
diff --git a/Open-ILS/src/eg2/src/styles.css b/Open-ILS/src/eg2/src/styles.css
index a959e8cf69..10424f2722 100644
--- a/Open-ILS/src/eg2/src/styles.css
+++ b/Open-ILS/src/eg2/src/styles.css
@@ -125,11 +125,11 @@ h5 {font-size: .95rem}
 }
 
 /* Limit size of dropdown menus and allow for scrolling */
-.dropdown-menu {
+.scrollable-menu {
   height: auto;
   max-height: 300px;
   overflow-y: auto;
-  font-size: 98%;
+  font-size: 99%;
 }
 
 /* --------------------------------------------------------------------------