From: Ben Shum <bshum@biblio.org>
Date: Tue, 21 Jan 2014 18:52:49 +0000 (-0500)
Subject: LP1271218 - clarify how opt-in user notifications are shown in my account
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=8ca1ea0a1abb6bf391135801cf1f808b331fb4cd;p=evergreen%2Fmasslnc.git

LP1271218 - clarify how opt-in user notifications are shown in my account

As reported in LP127128, end users may not need to be shown the message that
"No notification preferences are configured" when in fact this message is only
displayed when the user opt-in notification settings are not configured.

So, alter this to only show the table and div when there are settings to be
configured and otherwise show nothing.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/src/templates/opac/myopac/prefs_notify.tt2 b/Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
index 0663d86346..46bce63ee8 100644
--- a/Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
+++ b/Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
@@ -79,10 +79,8 @@
         </tbody>
     </table>
 
+    [% IF ctx.opt_in_settings.size > 0 %]
     <div class='user_opt_in_settings'>
-    [% IF ctx.opt_in_settings.size == 0 %]
-      <strong>[% l('No notification preferences are configured') %]</strong>
-    [% ELSE %]
       <table>
         <thead><tr>
             <th>[% l('Notification Type') %]</th>
@@ -101,8 +99,8 @@
             [% END %]
         </tbody>
       </table>
-    [% END %]
     </div>
+    [% END %]
     <input type='submit' value="[% l('Save') %]" alt="[% l('Save') %]" class="opac-button" />
 </form>
 [% END %]