From: Chris Sharp <csharp@georgialibraries.org>
Date: Wed, 2 Jan 2019 12:21:56 +0000 (-0500)
Subject: LP#1810296: Fix selfcheck patron password setting check
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=8dbed790a80e75ffc24d573c86ed9b44e4509bec;p=evergreen%2Fpines.git

LP#1810296: Fix selfcheck patron password setting check

Previously, the selfcheck ignored this setting if it was
set to "False", since the setting value is stored as text
and the truth test always succeeded.  Instead, explicitly
check that the setting is "True".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
---

diff --git a/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js b/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js
index c8859ac206..aaeba9617a 100644
--- a/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js
+++ b/Open-ILS/web/js/ui/default/circ/selfcheck/selfcheck.js
@@ -349,7 +349,7 @@ SelfCheckManager.prototype.drawLoginPage = function() {
     var bcHandler = function(barcode_or_usrname) {
         // handle patron barcode/usrname entry
 
-        if(self.orgSettings[SET_PATRON_PASSWORD_REQUIRED]) {
+        if(self.orgSettings[SET_PATRON_PASSWORD_REQUIRED] == 'True') {
             
             // password is required.  wire up the scan box to read it
             self.updateScanBox({
@@ -391,7 +391,7 @@ SelfCheckManager.prototype.loginPatron = function(barcode_or_usrname, passwd) {
         usrname = barcode_or_usrname;
     }
 
-    if(this.orgSettings[SET_PATRON_PASSWORD_REQUIRED]) {
+    if(this.orgSettings[SET_PATRON_PASSWORD_REQUIRED] == 'True') {
         
         if(!passwd) {
             // would only happen in dev/debug mode when using the patron= param