From: Jason Etheridge <jason@EquinoxOLI.org>
Date: Mon, 28 Nov 2022 04:24:47 +0000 (-0500)
Subject: provide warnings for missing optional fields
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=8e63f188afafd3a43370697b315984317a34bc0c;p=working%2FSIPServer.git

provide warnings for missing optional fields
---

diff --git a/t/SIPtest.pm b/t/SIPtest.pm
index 8e86524..7e03c4b 100644
--- a/t/SIPtest.pm
+++ b/t/SIPtest.pm
@@ -298,6 +298,9 @@ sub one_msg {
                 }
                 return;
             }
+            if (!$ftest->{required} && !exists($fields{$field})) {
+                diag("WARNING: $test->{id}: optional field '$field' not found in msg " . substr($resp,0,2));
+            }
 
             if (exists($fields{$field}) && (decode_utf8($fields{$field}) !~ $ftest->{pat})) {
                 diag("Field '$field' pattern '$ftest->{pat}' fails to match value '$fields{$field}' in message '$resp'");