From: Galen Charlton Date: Thu, 12 Sep 2013 19:37:57 +0000 (-0700) Subject: LP#1224647: remove two invalid tests X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=9028b0238106923a64534b88eb6382bf59783ea5;p=working%2FOpenSRF.git LP#1224647: remove two invalid tests The patch for bug 1204123 changes the client_recv() to not set the transport_client error flag, as most of the circumstances where it would have been set were for cases where the call to select() was interrupted by a signal, which is not an error per se. This patch removes two tests that were therefore made invalid, restoring the ability of the test suite to pass. Signed-off-by: Galen Charlton Signed-off-by: Bill Erickson --- diff --git a/tests/check_transport_client.c b/tests/check_transport_client.c index 741263f..0373290 100644 --- a/tests/check_transport_client.c +++ b/tests/check_transport_client.c @@ -155,8 +155,6 @@ START_TEST(test_transport_client_recv) transport_message *msg2 = client_recv(other_client, -1); fail_unless(msg2 == NULL, "client_recv should return NULL if the call to session_wait() returns an error"); - fail_unless(other_client->error == 1, - "client_recv should set client->error to true if an error has occured"); //message in queue with no timeout transport_message *msg3 = client_recv(a_client, -1); @@ -190,8 +188,6 @@ START_TEST(test_transport_client_recv) transport_message *msg5 = client_recv(other_client, 1); //only 1 sec again... fail_unless(msg5 == NULL, "client_recv should return NULL if there is an error"); - fail_unless(other_client->error == 1, - "client_recv should set client->error to 1 if there is an error"); END_TEST START_TEST(test_transport_client_free)