From: Dan Wells <dbw2@calvin.edu>
Date: Thu, 28 Jan 2016 19:49:42 +0000 (-0500)
Subject: LP#1526547 Improve note setting for backdates
X-Git-Tag: sprint4-merge-nov22~670
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=940d1acc79830f291fc5680dbb6758b8320c3563;p=working%2FEvergreen.git

LP#1526547 Improve note setting for backdates

The backdate note was the default note for voiding and adjusting, but
this proved to be an unexpected default.

Let's set the note only where we need it, and also genericize the
wording to cover both voiding and adjusting.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
index 3e438ce69c..5e256b15e9 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
@@ -604,7 +604,7 @@ sub post_checkin_backdate_circ_impl {
     $e->update_action_circulation($circ) or return $e->die_event;
 
     # now void the overdues "erased" by the back-dating
-    my $evt = OpenILS::Application::Circ::CircCommon->void_or_zero_overdues($e, $circ, {backdate => $backdate});
+    my $evt = OpenILS::Application::Circ::CircCommon->void_or_zero_overdues($e, $circ, {backdate => $backdate, note => 'System: OVERDUE REVERSED FOR BACKDATE'});
     return $evt if $evt;
 
     # If the circ was closed before and the balance owned !=0, re-open the transaction
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
index 62b5b57bab..f06a9ee7ca 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/CircCommon.pm
@@ -879,7 +879,7 @@ sub void_bills {
         $bill->voider($e->requestor->id);
         $bill->void_time('now');
         my $n = ($bill->note) ? sprintf("%s\n", $bill->note) : "";
-        $bill->note(sprintf("$n%s", ($note) ? $note : "System: VOIDED FOR BACKDATE"));
+        $bill->note(sprintf("$n%s", $note));
 
         $e->update_money_billing($bill) or return $e->die_event;
         my $evt = $U->check_open_xact($e, $bill->xact, $xact);