From: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov>
Date: Fri, 10 Jun 2022 20:20:14 +0000 (-0400)
Subject: do not delete/reinsert stat cats on chage, do update instead.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=951da56be2bd0b19d3491de3e33613ab5c0a9bad;p=working%2FEvergreen.git

do not delete/reinsert stat cats on chage, do update instead.
---

diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
index ac1894ce45..c5f76f004f 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
@@ -1152,20 +1152,22 @@ angular.module('egCoreMod')
 
             if (existing) { // we have a mapping
                 // if the existing mapping matches the new one,
-                // there' nothing left to do
+                // there's nothing left to do
                 if (existing.stat_cat_entry() == value) return;
 
-                // mappings differ.  delete the old one and create
-                // a new one below.
-                existing.isdeleted(true);
+                // mappings differ. Update existing.
+                existing.stat_cat_entry(value);
+                existing.ischanged(true);
+            }
+            else{
+                // create new mapping
+                var newmap = new egCore.idl.actscecm();
+                newmap.target_usr(patron.id());
+                newmap.isnew(true);
+                newmap.stat_cat(cat_id);
+                newmap.stat_cat_entry(value);
+                patron.stat_cat_entries().push(newmap);
             }
-
-            var newmap = new egCore.idl.actscecm();
-            newmap.target_usr(patron.id());
-            newmap.isnew(true);
-            newmap.stat_cat(cat_id);
-            newmap.stat_cat_entry(value);
-            patron.stat_cat_entries().push(newmap);
         });
 
         var waiver_hashes = patron.waiver_entries();