From: Jason Etheridge Date: Wed, 26 Apr 2017 21:23:26 +0000 (-0400) Subject: LP#1491875: avoid erroneous "unsaved data" popup during MARC record creation X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=956432ce699f8da594f28b60fbc42a5d592fd1a6;p=working%2FEvergreen.git LP#1491875: avoid erroneous "unsaved data" popup during MARC record creation Test plan --------- [1] Navigate to Cataloging -> Create New MARC Record. [2] Choose a template, click Load [3] Enter data in a fixed field, for example, Date1 [4] Enter data in a MARC field such as 100 [5] Click Create Record: The "This tab may have unsaved data. ..." pop up will appear. Clicking OK will save the record and take the user to their default view of the record. Clicking Cancel will save the record and return the user to the MARC Edit screen. The behavior when clicking Cancel can lead to confusion as to whether the record has actually been saved. [6] Apply the patch and repeats steps #1-#5. [7] This time, no extraneous unsaved data warning should appear. Note that this patch's kludge doesn't fix all possible instances of the warning; see https://bugs.launchpad.net/evergreen/+bug/1491875/comments/6 for details. Signed-off-by: Jason Etheridge SIgned-off-by: Andrea Neiman Signed-off-by: Galen Charlton --- diff --git a/Open-ILS/xul/staff_client/server/cat/marcedit.js b/Open-ILS/xul/staff_client/server/cat/marcedit.js index dca52a68d3..68bf3a30e3 100644 --- a/Open-ILS/xul/staff_client/server/cat/marcedit.js +++ b/Open-ILS/xul/staff_client/server/cat/marcedit.js @@ -1242,6 +1242,7 @@ function save_attempt(xml_string) { tab.marc_edit_changed = false; } oils_unlock_page(); + oils_unlock_page(); /* kludge for LP1491875 */ if (result.id) { replace_on_complete = fastItemAdd_attempt(result.id); }