From: Steven Callender <stevecallender@esilibrary.com>
Date: Fri, 4 Dec 2020 14:59:25 +0000 (-0500)
Subject: LP1906842 PLACE_UNFILLABLE_HOLD permission not working if no titles exist
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=96866a62d9cf555336b8622983173d94e069a452;p=evergreen%2Ftadl.git

LP1906842 PLACE_UNFILLABLE_HOLD permission not working if no titles exist

This fix will correct an issue where the screen just keeps looping to
the override screen when trying to place a hold that has no titles
available for it.

Patch courtesy of Mike Rylander.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index 12eada6051..f5489369ed 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -105,7 +105,7 @@ sub test_and_create_hold_batch {
         my $res;
         ($res) = $self->method_lookup(
             'open-ils.circ.title_hold.is_possible')->run($auth, $params, $override ? $oargs : {});
-        if ($res->{'success'} == 1) {
+        if ($res->{'success'} == 1 || ($override && $res->{place_unfillable})) {
 
             $params->{'depth'} = $res->{'depth'} if $res->{'depth'};