From: Bill Erickson <berickxx@gmail.com>
Date: Mon, 24 Oct 2022 19:25:51 +0000 (-0400)
Subject: LP1901930 Patron stat/info return full data w/ invalid patron password
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=982e4d93f04a6c0055c564e7922dd7d24219e82d;p=working%2FEvergreen.git

LP1901930 Patron stat/info return full data w/ invalid patron password

Consistent with the current Evergreen SIP server, return all info on
patrons for the patron status / information messages even if the
provided patron password is not correct.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
index b0b32225b6..c8f99b27a2 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
@@ -419,7 +419,7 @@ sub patron_response_common_data {
             {BH => $session->config->{settings}->{currency}},
             {BL => $SC->sipbool(1)},          # valid patron
             {BV => $details->{balance_owed}}, # fee amount
-            {CQ => $SC->sipbool($password)}   # password verified if exists
+            {CQ => $SC->sipbool($details->{valid_patron_password})}
         ]
     };
 }
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Patron.pm
index f757297589..86da493874 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Patron.pm
@@ -19,7 +19,7 @@ sub get_patron_details {
     my $password = $params{password};
 
     my $e = $session->editor;
-    my $details = {};
+    my $details = {valid_patron_password => 0};
 
     my $card = $e->search_actor_card([{
         barcode => $barcode
@@ -43,9 +43,12 @@ sub get_patron_details {
     $card->usr($card->usr->id);
     $patron->card($card);
 
-    # We only attempt to verify the password if one is provided.
-    return undef if defined $password &&
-        !$U->verify_migrated_user_password($e, $patron->id, $password);
+    if (defined $password) {
+        # SIP still replies with the patron data if the password
+        # is not valid.
+        $details->{valid_patron_password} = 
+            $U->verify_migrated_user_password($e, $patron->id, $password);
+    }
 
     set_patron_privileges($session, $details);