From: senator <senator@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Fri, 17 Dec 2010 19:26:05 +0000 (+0000)
Subject: Acq: Tracked down a small but subtle bug with the Holding Subfield tab of
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=9a3f03c6e3cb82a51eccaa0149eccda6aaf4fd68;p=evergreen%2Fbjwebb.git

Acq: Tracked down a small but subtle bug with the Holding Subfield tab of
the Provider editor interface.

We apparently have a global variable "name" defined somewhere which, when
assigned in place of an overrideWidget for an AutoGrid thanks to some vestigial
code, ultimately causes an error from within AutoFieldWidget, if you're using
the staff client.  That's because name is the string "browser_browser" in the
staff client, but if you access this interface from Firefox, name is apparently
set to some value that evaluates to false in a boolean context, because
AutoFieldWidget doesn't choke on it (the comparison at line 182 of that file
will return false).


git-svn-id: svn://svn.open-ils.org/ILS/trunk@19013 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/web/js/ui/default/conify/global/acq/provider.js b/Open-ILS/web/js/ui/default/conify/global/acq/provider.js
index b3abfed4d..76c63a516 100644
--- a/Open-ILS/web/js/ui/default/conify/global/acq/provider.js
+++ b/Open-ILS/web/js/ui/default/conify/global/acq/provider.js
@@ -81,7 +81,6 @@ function drawProviderSummary(child) {
         case 'tab-hold': 
             phsListGrid.overrideEditWidgets.provider = new
                 dijit.form.TextBox({disabled: 'true', value: providerId});
-            phsListGrid.overrideEditWidgets.name = name;
             phsListGrid.resetStore();
             phsListGrid.loadAll({order_by:{acqphsm : 'name'}}, {provider : providerId});
             break;