From: Mike Rylander <mrylander@gmail.com>
Date: Mon, 29 Jan 2018 21:37:15 +0000 (-0500)
Subject: LP#1707063: Naive ng-class test for last-column-modified
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=9a3fc01d601b23ce49864ca490c8319a9306103b;p=working%2FEvergreen.git

LP#1707063: Naive ng-class test for last-column-modified

Instead of comparing a (potentially undefined) property of a column, we'll
just compare the column object directly when checking to see if a column
header should be highlighted for "last touched in editing mode."

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/templates/staff/share/t_autogrid.tt2 b/Open-ILS/src/templates/staff/share/t_autogrid.tt2
index e8f94d77bd..a1d60d5097 100644
--- a/Open-ILS/src/templates/staff/share/t_autogrid.tt2
+++ b/Open-ILS/src/templates/staff/share/t_autogrid.tt2
@@ -223,7 +223,7 @@
     </div>
     <div class="eg-grid-cell"
         eg-grid-column-drag-dest
-        ng-class="{'eg-grid-column-last-mod' : lastModColumn==col.name}"
+        ng-class="{'eg-grid-column-last-mod' : isLastModifiedColumn(col)}"
         column="{{col.name}}"
         eg-right-click="onContextMenu($event)"
         ng-repeat="col in columns"
diff --git a/Open-ILS/web/js/ui/default/staff/services/grid.js b/Open-ILS/web/js/ui/default/staff/services/grid.js
index fab8679d69..e18cf69a6e 100644
--- a/Open-ILS/web/js/ui/default/staff/services/grid.js
+++ b/Open-ILS/web/js/ui/default/staff/services/grid.js
@@ -761,10 +761,16 @@ angular.module('egGridMod',
                     column.flex = 1;
             }
             $scope.modifyColumnFlex = function(col, val) {
-                $scope.lastModColumn = col.name;
+                $scope.lastModColumn = col;
                 grid.modifyColumnFlex(col, val);
             }
 
+            $scope.isLastModifiedColumn = function(col) {
+                if ($scope.lastModColumn)
+                    return $scope.lastModColumn === col;
+                return false;
+            }
+
             grid.modifyColumnPos = function(col, diff) {
                 var srcIdx, targetIdx;
                 angular.forEach(grid.columnsProvider.columns,
@@ -790,7 +796,7 @@ angular.module('egGridMod',
             }
 
             $scope.modifyColumnPos = function(col, diff) {
-                $scope.lastModColumn = col.name;
+                $scope.lastModColumn = col;
                 return grid.modifyColumnPos(col, diff);
             }