From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Mon, 16 Oct 2006 16:22:39 +0000 (+0000)
Subject: wrapped some money-transaction fetching methods in transactions to
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=9c7972d4003469518d975c545cadc2f549293bbe;p=Evergreen.git

wrapped some money-transaction fetching methods in transactions to
prevent replication delays


git-svn-id: svn://svn.open-ils.org/ILS/trunk@6472 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm b/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
index 751b35d2ba..f1c4c80f43 100644
--- a/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
@@ -1319,9 +1319,12 @@ sub user_fines_summary {
 			$e->allowed('VIEW_USER_FINES_SUMMARY', $user->home_ou);
 	}
 	
-	return $apputils->simple_scalar_request( 
-		'open-ils.storage',
-		'open-ils.storage.money.open_user_summary.search', $user_id );
+	# run this inside a transaction to prevent replication delay errors
+	my $ses = $U->start_db_session();
+	my $s = $ses->request(
+		'open-ils.storage.money.open_user_summary.search', $user_id )->gather(1);
+	$U->rollback_db_session($ses);
+	return $s;
 }
 
 
@@ -2029,9 +2032,11 @@ sub _make_mbts {
 
 sub user_transaction_history {
 	my( $self, $conn, $auth, $userid, $type ) = @_;
-	my $e = new_editor(authtoken=>$auth);
-	return $e->event unless $e->checkauth;
-	return $e->event unless $e->allowed('VIEW_USER_TRANSACTIONS');
+
+	# run inside of a transaction to prevent replication delays
+	my $e = new_editor(xact=>1, authtoken=>$auth);
+	return $e->die_event unless $e->checkauth;
+	return $e->die_event unless $e->allowed('VIEW_USER_TRANSACTIONS');
 
 	my $api = $self->api_name;
 	my @xact_finish  = (xact_finish => undef ) if ($api =~ /history.still_open$/);
@@ -2045,6 +2050,8 @@ sub user_transaction_history {
 		]
 	) };
 
+	$e->rollback;
+
 	my @mbts = _make_mbts( @xacts );
 
 	if(defined($type)) {