From: Jared Camins-Esakov <jcamins@cpbibliography.com>
Date: Tue, 21 Aug 2012 17:50:06 +0000 (-0400)
Subject: Fix uninitialized variable in abstract_query2str_impl
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=a21da586f1c7cd978dca57b018c3f1ca18f07336;p=working%2FEvergreen.git

Fix uninitialized variable in abstract_query2str_impl

Because abstract_query2str_impl can be called without the depth
parameter, it is easy to end up in a situation where you are getting
lots of warnings, and not getting group end markers.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/QueryParser.pm
index 7ee0402dd4..3afb9d7da9 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/QueryParser.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/QueryParser.pm
@@ -883,6 +883,7 @@ sub _abstract_query2str_modifier {
 # abstract_query.
 sub abstract_query2str_impl {
     my ($abstract_query, $depth) = @_;
+    $depth |= 0;
 
     my $qpconfig = $parser_config{QueryParser};