From: Dan Briem <dbriem@wlsmail.org>
Date: Thu, 20 May 2021 17:05:21 +0000 (-0400)
Subject: LP#1928684 Catalog view holds tab sort by patron barcode error
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=aba07e90328dbc6276f7457bcdd17b5072ff762a;p=evergreen%2Ftadl.git

LP#1928684 Catalog view holds tab sort by patron barcode error

This changes the Patron Barcode column name to ucard_barcode to
match the field name in the database.

Note: due to the name change, users who saved the column on the
grid will have to add it again.

To test:
1. Go to the View Holds tab on a record that has hold requests
2. Add the Patron Barcode column to the grid
3. Sort by the barcode column and note that it works
4. It's a good idea to test that the grid settings save properly

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---

diff --git a/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html b/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html
index 84bb536332..f0dce3558c 100644
--- a/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.html
@@ -132,7 +132,7 @@
           {{hold.ucard_barcode}}
         </a>
       </ng-template>
-      <eg-grid-column i18n-label label="Patron Barcode" name="patron_barcode"
+      <eg-grid-column i18n-label label="Patron Barcode" path="ucard_barcode"
         [cellTemplate]="userBarcodeTmpl" [hidden]="true"></eg-grid-column>
 
       <eg-grid-column i18n-label label="Patron alias" path="usr_alias"></eg-grid-column>
diff --git a/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts b/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts
index 92a2538aca..3a95b05139 100644
--- a/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/share/holds/grid.component.ts
@@ -185,7 +185,7 @@ export class HoldsGridComponent implements OnInit {
         this.cellTextGenerator = {
             title: row => row.title,
             cp_barcode: row => (row.cp_barcode == null) ? '' : row.cp_barcode,
-            patron_barcode: row => row.ucard_barcode
+            ucard_barcode: row => row.ucard_barcode
         };
     }