From: Jeff Davis <jdavis@sitka.bclibraries.ca>
Date: Tue, 8 Oct 2019 23:00:12 +0000 (-0700)
Subject: LP#1847343: fix Exclude Electronic Resources checkbox when locale picker is enabled
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=ad4ec5958a1a17def4405dc6cce737e92a853009;p=Evergreen.git

LP#1847343: fix Exclude Electronic Resources checkbox when locale picker is enabled

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/web/js/ui/default/opac/simple.js b/Open-ILS/web/js/ui/default/opac/simple.js
index e121fd188f..abf50c7da1 100644
--- a/Open-ILS/web/js/ui/default/opac/simple.js
+++ b/Open-ILS/web/js/ui/default/opac/simple.js
@@ -108,11 +108,9 @@ function exclude_onchange(checkbox) {
         var reg = /-search_format\(electronic\)/g;
         search_box.value = search_box.value.replace(reg, "");
         // Remove from the search form itself
-        var search_format_inputs = document.getElementsByName("fi:-search_format");
+        var search_format_inputs = document.querySelectorAll('input[type="hidden"][name="fi:-search_format"][value="electronic"]');
         for (var j = 0; j < search_format_inputs.length; j++) {
-            if (search_format_inputs[j].value == 'electronic') {
-                search_format_inputs[j].parentNode.removeChild(search_format_inputs[j]);
-            }
+            search_format_inputs[j].parentNode.removeChild(search_format_inputs[j]);
         }
 
     }