From: Dan Pearl <dpearl@cwmars.org>
Date: Tue, 20 May 2014 17:12:47 +0000 (-0400)
Subject: LP#1321363: Suppress Hold Transit use elicits client error
X-Git-Tag: sprint4-merge-nov22~2108
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=b102ce25d6340648af38fce160dc5be3a38e04fa;p=working%2FEvergreen.git

LP#1321363: Suppress Hold Transit use elicits client error

This change restores the behavior as designed.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 5f7386040a..4fec8e4ef6 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -3032,7 +3032,7 @@ sub attempt_checkin_hold_capture {
             my $suppress_transit_pickup = $U->ou_ancestor_setting($hold->pickup_lib, 'circ.transit.suppress_hold');
             if($suppress_transit_pickup && $suppress_transit_circ->{value} eq $suppress_transit_pickup->{value}) {
                 $suppress_transit = 1;
-                $self->hold->pickup_lib($self->circ_lib);
+                $hold->pickup_lib($self->circ_lib);
             }
         }
     }