From: phasefx <phasefx@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Wed, 29 Jul 2009 09:31:15 +0000 (+0000)
Subject: This works either way.  list.append( row_params ) will return a modified row_params... 
X-Git-Tag: sprint4-merge-nov22~9591
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=b44d110c3e0c7ed15f30825f544ae737a8096638;p=working%2FEvergreen.git

This works either way.  list.append( row_params ) will return a modified row_params, but row_params is modified by reference in any case



git-svn-id: svn://svn.open-ils.org/ILS/trunk@13775 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/xul/staff_client/server/patron/standing_penalties.js b/Open-ILS/xul/staff_client/server/patron/standing_penalties.js
index 622deb22b7..1c54e89439 100644
--- a/Open-ILS/xul/staff_client/server/patron/standing_penalties.js
+++ b/Open-ILS/xul/staff_client/server/patron/standing_penalties.js
@@ -93,8 +93,7 @@ function populate_list() {
                     }
                 }
             };
-            rows[ xulG.patron.standing_penalties()[i].id() ] = function(p){ return p; }(row_params); // careful with vars in loops
-            list.append( row_params );
+            rows[ xulG.patron.standing_penalties()[i].id() ] = list.append( row_params );
         };
 
     } catch(E) {
@@ -160,8 +159,7 @@ function generate_request_handler_for_penalty_apply(penalty,id) {
                         }
                     }
                 };
-                rows[ penalty.id() ] = row_params;
-                list.append( row_params );
+                rows[ penalty.id() ] = list.append( row_params );
             }
             /*
             if (xulG && typeof xulG.refresh == 'function') {