From: Galen Charlton <gmc@equinoxinitiative.org>
Date: Fri, 11 Aug 2017 16:23:01 +0000 (-0400)
Subject: LP#1659928: fix regression introduce by previous patches
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=b45f7d99938f02f39a37ebecbed5099dcb4c84b5;p=working%2FEvergreen.git

LP#1659928: fix regression introduce by previous patches

A couple other places that use the standing_penalty list needed to
be adjusted to account for the non-de-fleshing.

Kudos to Jason Etheridge for noting the live_t test failure. Also,
unit tests FTW.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
index cf6375ac21..9e593e5d50 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
@@ -469,7 +469,7 @@ sub too_many_charged {      # not implemented
 sub too_many_overdue { 
     my $self = shift;
     return scalar( # PATRON_EXCEEDS_OVERDUE_COUNT
-        grep { $_ == OILS_PENALTY_PATRON_EXCEEDS_OVERDUE_COUNT } @{$self->{user}->standing_penalties}
+        grep { $_->id == OILS_PENALTY_PATRON_EXCEEDS_OVERDUE_COUNT } @{$self->{user}->standing_penalties}
     );
 }
 
@@ -494,7 +494,7 @@ sub too_many_lost {
 sub excessive_fines { 
     my $self = shift;
     return scalar( # PATRON_EXCEEDS_FINES
-        grep { $_ == OILS_PENALTY_PATRON_EXCEEDS_FINES } @{$self->{user}->standing_penalties}
+        grep { $_->id == OILS_PENALTY_PATRON_EXCEEDS_FINES } @{$self->{user}->standing_penalties}
     );
 }