From: djfiander <djfiander@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Fri, 20 Mar 2009 00:57:45 +0000 (+0000)
Subject: minor error checking
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=b717a49ea9fc17fa4fec22324979345bb984ce8e;p=Evergreen.git

minor error checking


git-svn-id: svn://svn.open-ils.org/ILS/trunk@12620 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm b/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm
index b5068863e7..d4f38c90ce 100755
--- a/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm
+++ b/Open-ILS/src/perlmods/OpenILS/Utils/MFHD/Caption.pm
@@ -356,11 +356,13 @@ my %dispatch = (
 		's' => \&match_season,
 		'y' => \&match_year,
 );
+
 sub regularity_match {
     my $self = shift;
     my $pubcode = shift;
     my @date = @_;
 
+    # we can't match something that doesn't exist.
     return 0 if !exists $self->{_mfhdc_PATTERN}->{y};
 
     foreach my $regularity (@{$self->{_mfhdc_PATTERN}->{y}}) {
@@ -369,6 +371,11 @@ sub regularity_match {
 	my $chroncode= substr($regularity, 1, 1);
 	my @pats = split(/,/, substr($regularity, 2));
 
+	if (!exists $dispatch{$chroncode}) {
+	    carp "Unrecognized chroncode '$chroncode'";
+	    return 0;
+	}
+
 	# XXX WRITE ME
 	foreach my $pat (@pats) {
 	    $pat =~ s|/.+||;	# If it's a combined date, match the start