From: Bill Erickson <berickxx@gmail.com>
Date: Thu, 29 Jun 2017 21:53:33 +0000 (-0400)
Subject: LP#1694529 Claims never checked out updates patron last-xact-id
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=b746411600bdd210a5ee4abb1ffa194b6c4f2a0d;p=evergreen%2Fpines.git

LP#1694529 Claims never checked out updates patron last-xact-id

Force an upate to the user last_xact_id value when marking an item claims
never checked out, since the process results in patron record changes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 21b875d49c..ce05bc0c2f 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -290,6 +290,16 @@ sub run_method {
 
     } else {
 
+        # checkin and reservation return can result in modifications to
+        # actor.usr.claims_never_checked_out_count without also modifying
+        # actor.last_xact_id.  Perform a no-op update on the patron to
+        # force an update to last_xact_id.
+        if ($circulator->claims_never_checked_out && $circulator->patron) {
+            $circulator->editor->update_actor_user(
+                $circulator->editor->retrieve_actor_user($circulator->patron->id))
+                or return $circulator->editor->die_event;
+        }
+
         $circulator->editor->commit;
     }