From: Bill Erickson <berickxx@gmail.com>
Date: Tue, 28 Feb 2017 16:33:25 +0000 (-0500)
Subject: LP#1668682 Checkout holds fullfill ignores expire time
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=b9cab5c6bcbb459cd9fc17bec0c12640cd42c9cc;p=working%2FEvergreen.git

LP#1668682 Checkout holds fullfill ignores expire time

Checking out a hold-captured item for a hold whose expire time is in the
past, but has not yet been canceled by the hold targeter, now marks the
hold as fulfilled.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index ad6fff2c91..0d815e6191 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -1559,11 +1559,7 @@ sub handle_checkout_holds {
     my $hold = $e->search_action_hold_request({   
         current_copy        => $copy->id , 
         cancel_time         => undef, 
-        fulfillment_time    => undef,
-        '-or' => [
-            {expire_time => undef},
-            {expire_time => {'>' => 'now'}}
-        ]
+        fulfillment_time    => undef
     })->[0];
 
     if($hold and $hold->usr != $patron->id) {