From: Thomas Berezansky <tsbere@mvlc.org>
Date: Thu, 12 Jul 2012 15:42:21 +0000 (-0400)
Subject: Remove an extra ternary op
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=ba24ca916ff5b943d5f6b36177c3f34a27399084;p=contrib%2FConifer.git

Remove an extra ternary op

And adjust the comment to make more sense. There is no higher level filter
that prevents copy holds on parted items, so there is no filter for them to
"slip through".

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index 640525c774..4101309eae 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -1268,8 +1268,8 @@ sub new_hold_copy_targeter {
 							isTrue($_->holdable) &&
 							!isTrue($_->deleted) &&
 							(isTrue($hold->mint_condition) ? isTrue($_->mint_condition) : 1) &&
-							( ($hold->hold_type ne 'C' && $hold->hold_type ne 'I') ? # Copy-ish holds can target if they slipped through
-								($hold->hold_type ne 'P' ? $_->part_maps->count == 0 : 1) : 1 )
+							( ( $hold->hold_type ne 'C' && $hold->hold_type ne 'I' # Copy-level holds don't care about parts
+								&& $hold->hold_type ne 'P' ) ? $_->part_maps->count == 0 : 1)
 						} @$all_copies;
 			}