From: Bill Erickson <berickxx@gmail.com>
Date: Sun, 4 Apr 2021 21:36:45 +0000 (-0400)
Subject: LP1904036 User setting values may be null
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=ba6c2dbf395a27e79ff74ff0a0c75db799f579b4;p=working%2FEvergreen.git

LP1904036 User setting values may be null

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---

diff --git a/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.ts b/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.ts
index dcf97214c8..508e22c548 100644
--- a/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/circ/patron/edit.component.ts
@@ -1449,7 +1449,8 @@ export class EditComponent implements OnInit, AfterViewInit {
                 newValue = this.patron[field]();
 
             } else if (matches = field.match(/(\w+)_notify/)) {
-                newValue = this.userSettings['opac.hold_notify'].match(matches[1]) !== null;
+                const holdNotify = this.userSettings['opac.hold_notify'] || '';
+                newValue = holdNotify.match(matches[1]) !== null;
             }
 
             const oldValue = this.holdNotifyValues[field];