From: Galen Charlton Date: Fri, 4 Oct 2013 21:44:56 +0000 (-0700) Subject: LP#1235474: fix failure of authority browse context menu to render X-Git-Tag: sprint4-merge-nov22~2424 X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=bb5a18038514cac32c9314a4f39e4625b4e6c270;p=working%2FEvergreen.git LP#1235474: fix failure of authority browse context menu to render This patch fixes a situation where if an authority record that would be brought up by the authority browse context menu in the MARC editor lacks an 003 field, the context menu would not be rendered all, meaning that the default context menu (e.g., cut/copy/paste/etc.) would be displayed instead. Signed-off-by: Galen Charlton Signed-off-by: Dan Scott --- diff --git a/Open-ILS/xul/staff_client/server/cat/marcedit.js b/Open-ILS/xul/staff_client/server/cat/marcedit.js index eee677e215..4292e78ac7 100644 --- a/Open-ILS/xul/staff_client/server/cat/marcedit.js +++ b/Open-ILS/xul/staff_client/server/cat/marcedit.js @@ -1847,7 +1847,10 @@ function browseAuthority (sf_popup, menu_id, target, sf, limit, page) { var see_from = []; var see_also = []; var auth_id = dojox.xml.parser.textContent(dojo.query('datafield[tag="901"]', record).query('subfield[code="c"]')[0]); - var auth_org = dojox.xml.parser.textContent(dojo.query('controlfield[tag="003"]', record)[0]); + var auth_org = ''; + if (dojo.query('controlfield[tag="003"]', record).length > 0) { + auth_org = dojox.xml.parser.textContent(dojo.query('controlfield[tag="003"]', record)[0]); + } // Grab the fields with tags beginning with 1 (main entries) and iterate through the subfields dojo.query('datafield[tag^="1"]', record).forEach(function(field) {