From: Mike Rylander Date: Fri, 7 Jul 2017 19:34:57 +0000 (-0400) Subject: LP#1702978: memcache Remove method used in a variadic way X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=bbed9d96e78b7e567bddb31dbdd18d23c5e9563b;p=working%2FEvergreen.git LP#1702978: memcache Remove method used in a variadic way Related to the OpenSRF branch on this same bug, the prevents Evergreen from using a to-be-non-variadic memcache method in that way. This prevents issues for memcache keys that contain a %. Signed-off-by: Mike Rylander --- diff --git a/Open-ILS/src/c-apps/oils_auth.c b/Open-ILS/src/c-apps/oils_auth.c index 0fd924fa21..3d29e2cf57 100644 --- a/Open-ILS/src/c-apps/oils_auth.c +++ b/Open-ILS/src/c-apps/oils_auth.c @@ -437,7 +437,9 @@ static int oilsAuthVerifyPassword( const osrfMethodContext* ctx, int user_id, int verified = 0; // We won't be needing the seed again, remove it - osrfCacheRemove("%s%s%s", OILS_AUTH_CACHE_PRFX, identifier, nonce); + char* key = va_list_to_string("%s%s%s", OILS_AUTH_CACHE_PRFX, identifier, nonce ); /**/ + osrfCacheRemove(key); + free(key); // Ask the DB to verify the user's password. // Here, the password is md5(md5(password) + salt)