From: Bill Erickson Date: Wed, 15 Feb 2012 22:07:24 +0000 (-0500) Subject: Update pickup lib from holds shelf status test repair X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=bd1e1adb4c60f518dac9f248d9eb477d68cced8b;p=working%2FEvergreen.git Update pickup lib from holds shelf status test repair When determining whether a hold is getting updated while already on the holds shelf, it's important to also treat hold status 5 as an on-shelf status. Status 5 comes into play when the circ.hold_shelf_status_delay org unit setting is activated and acts as a virtual status indicating the item is physically en route to the shelf. Signed-off-by: Bill Erickson Signed-off-by: Mike Rylander --- diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm index 58160db0de..5332eabe1f 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm @@ -838,7 +838,7 @@ sub update_hold_impl { $transit->dest($hold->pickup_lib); $e->update_action_hold_transit_copy($transit) or return $e->die_event; - } elsif($status == 4) { # on holds shelf + } elsif($status == 4 or $status == 5) { # on holds shelf return $e->die_event unless $e->allowed('UPDATE_PICKUP_LIB_FROM_HOLDS_SHELF', $orig_hold->pickup_lib); return $e->die_event unless $e->allowed('UPDATE_PICKUP_LIB_FROM_HOLDS_SHELF', $hold->pickup_lib);