From: Mike Rylander <mrylander@gmail.com>
Date: Wed, 25 May 2016 17:14:44 +0000 (-0400)
Subject: LP#1585369: Angular broke my copy editor!
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=bface48e0fff0512d46dee412bc46e8454521c5a;p=Evergreen.git

LP#1585369: Angular broke my copy editor!

It seems Angular 1.5 is either less flexible or less forgiving in its
ng-repeat implementation, and does not like an orderBy filter on object
iterators.  Removing that, and the track by clause, allows the holdings
editor to render properly.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/src/templates/staff/cat/volcopy/t_edit.tt2 b/Open-ILS/src/templates/staff/cat/volcopy/t_edit.tt2
index 95e8e5083f..30ac2d35a7 100644
--- a/Open-ILS/src/templates/staff/cat/volcopy/t_edit.tt2
+++ b/Open-ILS/src/templates/staff/cat/volcopy/t_edit.tt2
@@ -65,7 +65,7 @@
         </div> <!-- row -->
         <eg-vol-edit
             focus-next="focusNextFirst"
-            ng-repeat="(lib,callnumbers) in data.tree | orderBy:lib track by lib"
+            ng-repeat="(lib,callnumbers) in data.tree"
             ng-init="ind = $index"
             record="{{record_id}}"
             only-vols="only_vols"
diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index 8c9ce6827a..0b109da76c 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -626,7 +626,7 @@ function(egCore , $q) {
                 '<div class="col-xs-1"><input ng-disabled="record == 0" class="form-control" type="number" min="{{orig_cn_count}}" ng-model="cn_count" ng-change="changeCNCount()"/></div>'+
                 '<div class="col-xs-10">'+
                     '<eg-vol-row only-vols="onlyVols" record="{{record}}"'+
-                        'ng-repeat="(cn,copies) in struct | orderBy:cn track by cn" '+
+                        'ng-repeat="(cn,copies) in struct" '+
                         'focus-next="focusNextFirst" copies="copies" allcopies="allcopies">'+
                     '</eg-vol-row>'+
                 '</div>'+