From: Bill Erickson <berick@esilibrary.com>
Date: Wed, 3 Apr 2013 20:21:25 +0000 (-0400)
Subject: Ignore canceled holds during alt-queue generation
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c14818bb399ddb2a3bcb94a61fe5070ca12ceb22;p=evergreen%2Fmasslnc.git

Ignore canceled holds during alt-queue generation

When zero potential copies exist for a hold, the hold queue stats code
determines the size and shape of the queue by finding and sorting holds
that have the same type and target.  This patch forces the code to
ignore canceled holds when looking for similarly-shaped holds.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index 8e7e5f7f04..9ba8272fa6 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -1378,7 +1378,13 @@ sub retrieve_hold_queue_status_impl {
             ],
             where    => {
                 hold_type => $hold->hold_type,
-                target    => $hold->target
+                target    => $hold->target,
+                capture_time => undef,
+                cancel_time => undef,
+                '-or' => [
+                    {expire_time => undef },
+                    {expire_time => {'>' => 'now'}}
+                ]
            }
         });
     }