From: Dan Wells <dbw2@calvin.edu>
Date: Thu, 13 Feb 2014 16:56:19 +0000 (-0500)
Subject: LP#1526543 Truthiness check for reset_password is flawed
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c1cec9a95a25935d5f0e97d1c104ef5d093cef7e;p=evergreen%2Fmasslnc.git

LP#1526543 Truthiness check for reset_password is flawed

We expect boolean options in config.tt2 to be 'true' or 'false',
but the code was simple asking 'IF reset_password', which is true
for either value.

Instead, match on the string (as we do in other places).

To test:
- Load the stock catalog login page
- Notice the "Forgot your password?" link staying no matter which way
  'reset_password' is set in config.tt2
- Apply patch, and change 'reset_password' value in config.tt2 to 'false'
- RESULT: Password reset link doesn't show up

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/src/templates/opac/parts/login/form.tt2 b/Open-ILS/src/templates/opac/parts/login/form.tt2
index 9b13f587a2..88d42c91eb 100644
--- a/Open-ILS/src/templates/opac/parts/login/form.tt2
+++ b/Open-ILS/src/templates/opac/parts/login/form.tt2
@@ -31,7 +31,7 @@
                 <input id="password_field" name="password" type="password" />
             </div>
             [% INCLUDE "opac/parts/login/password_hint.tt2" %]
-            [% IF reset_password %]
+            [% IF reset_password == 'true' %]
             <a style="font-size: 80%" href='[% mkurl(ctx.opac_root _ '/password_reset', {}, 1) %]'>[% l('Forgot your password?') %]</a>
             [% END %]
         </div>