From: Jeff Godin <jgodin@tadl.org>
Date: Thu, 14 Mar 2013 18:15:28 +0000 (-0400)
Subject: Fix detection of empty Syndetics AC data elements
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c1fbf206283e52db46cc845ac4901c09d5ed501e;p=evergreen%2Ftadl.git

Fix detection of empty Syndetics AC data elements

Due to a change in how the vendor responds to requests for data
elements which are not present for a requested title, we need to
change how we detect "empty" data elements in the "data_exists"
function.

First, we check for the new "No Data Available" title element, then
we check for the previously-used value of "error".

This change resolves the symptom where the catalog would display
tabs for "Author Notes", "Excerpt", "Table of Contents", on every
record in the catalog, even when clicking each tab would show that
the content was not present / available.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/Syndetic.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/Syndetic.pm
index 287bbcfe48..a9ce2e0cf8 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/Syndetic.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/Syndetic.pm
@@ -179,6 +179,7 @@ sub reviews_json {
 
 sub data_exists {
     my( $self, $data ) = @_;
+    return 0 if $data =~ m/<title>No Data Available<\/title>/iog;
     return 0 if $data =~ m/<title>error<\/title>/iog;
     return 1;
 }