From: Bill Erickson <berickxx@gmail.com>
Date: Thu, 29 Jul 2021 20:02:44 +0000 (-0400)
Subject: LP1910452 Remove staff catalog read-only OPAC Patron View
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c20936e7af42d0fa0250685585faa18a64387b20;p=evergreen%2Fpines.git

LP1910452 Remove staff catalog read-only OPAC Patron View

This is superseded by a new Patron View button.

Also removes the underlying component, since it's not longer used
anywhere.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
---

diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/catalog.module.ts b/Open-ILS/src/eg2/src/app/staff/catalog/catalog.module.ts
index 4df2ffd2ad..89eb2b06ae 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/catalog.module.ts
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/catalog.module.ts
@@ -11,7 +11,6 @@ import {SearchFormComponent} from './search-form.component';
 import {ResultsComponent} from './result/results.component';
 import {RecordComponent} from './record/record.component';
 import {CopiesComponent} from './record/copies.component';
-import {OpacViewComponent} from './record/opac.component';
 import {ResultPaginationComponent} from './result/pagination.component';
 import {ResultFacetsComponent} from './result/facets.component';
 import {ResultRecordComponent} from './result/record.component';
@@ -57,7 +56,6 @@ import {BrowsePagerComponent} from './result/browse-pager.component';
     HoldingsMaintenanceComponent,
     SearchTemplatesComponent,
     CnBrowseComponent,
-    OpacViewComponent,
     PreferencesComponent,
     CnBrowseResultsComponent,
     BrowsePagerComponent
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/record/opac.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/record/opac.component.html
deleted file mode 100644
index adbaeec39e..0000000000
--- a/Open-ILS/src/eg2/src/app/staff/catalog/record/opac.component.html
+++ /dev/null
@@ -1,10 +0,0 @@
-
-<div *ngIf="!loaded" class="m-3 p-3 d-flex justify-content-center">
-  <div><img src="/images/progressbar_green.gif"/></div>
-</div>
-
-<ng-container *ngIf="url">
-  <iframe id='opac-iframe' class="w-100" (load)="handleLoad()" [src]="url">
-  </iframe> 
-</ng-container>
-
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/record/opac.component.ts b/Open-ILS/src/eg2/src/app/staff/catalog/record/opac.component.ts
deleted file mode 100644
index 98eadf38da..0000000000
--- a/Open-ILS/src/eg2/src/app/staff/catalog/record/opac.component.ts
+++ /dev/null
@@ -1,47 +0,0 @@
-import {Component, Input, Renderer2} from '@angular/core';
-import {DomSanitizer} from '@angular/platform-browser';
-
-const OPAC_BASE_URL = '/eg/opac/record';
-
-@Component({
-  selector: 'eg-opac-record-detail',
-  templateUrl: 'opac.component.html'
-})
-export class OpacViewComponent {
-
-    url; // SafeResourceUrlImpl
-    loaded: boolean;
-
-    _recordId: number;
-    @Input() set recordId(id: number) {
-
-        // Verify record ID is numeric only
-        if (id && (id + '').match(/^\d+$/)) {
-            this._recordId = id;
-            this.url = this.sanitizer.bypassSecurityTrustResourceUrl(
-                `${OPAC_BASE_URL}/${id}?readonly=1`);
-        } else {
-            this._recordId = null;
-            this.url = null;
-        }
-    }
-
-    get recordId(): number {
-        return this._recordId;
-    }
-
-    constructor(
-        private sanitizer: DomSanitizer,
-        private renderer: Renderer2) {}
-
-    handleLoad() {
-        const iframe = this.renderer.selectRootElement('#opac-iframe');
-
-        // 50 extra px adds enough space to avoid the scrollbar altogether
-        const height = 50 + iframe.contentWindow.document.body.offsetHeight;
-
-        iframe.style.height = `${height}px`;
-        this.loaded = true;
-    }
-}
-
diff --git a/Open-ILS/src/eg2/src/app/staff/catalog/record/record.component.html b/Open-ILS/src/eg2/src/app/staff/catalog/record/record.component.html
index 0630d3b6d8..693c288396 100644
--- a/Open-ILS/src/eg2/src/app/staff/catalog/record/record.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/catalog/record/record.component.html
@@ -94,12 +94,6 @@
           </ng-container>
         </ng-template>
       </ngb-tab>
-      <ngb-tab title="Patron View" i18n-title id="catalog">
-        <ng-template ngbTabContent>
-          <eg-opac-record-detail [recordId]="recordId">
-          </eg-opac-record-detail>
-        </ng-template>
-      </ngb-tab>
     </ngb-tabset>
   </div>
 </div>