From: Bill Erickson <berickxx@gmail.com>
Date: Thu, 29 Apr 2021 14:45:53 +0000 (-0400)
Subject: LP1888723 Prevent magic status change via template
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c20f63a9baf80c54aecac13185d4d4c5578062ce;p=working%2FEvergreen.git

LP1888723 Prevent magic status change via template

Put hard stop on changing a copy status to/from a "magic" system status
via template.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/copy-attrs.component.html b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/copy-attrs.component.html
index 632640a52b..51905142f9 100644
--- a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/copy-attrs.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/copy-attrs.component.html
@@ -101,7 +101,7 @@
 
       <ng-template #noEditStat>
         <eg-batch-item-attr label="Status" i18n-label [readOnly]="true"
-          [labelCounts]="itemAttrCounts('status')">
+          name="status" [labelCounts]="itemAttrCounts('status')">
         </eg-batch-item-attr>
       </ng-template>
     </div>
diff --git a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/copy-attrs.component.ts b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/copy-attrs.component.ts
index 1967a77445..ebff70268a 100644
--- a/Open-ILS/src/eg2/src/app/staff/cat/volcopy/copy-attrs.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/cat/volcopy/copy-attrs.component.ts
@@ -286,6 +286,14 @@ export class CopyAttrsComponent implements OnInit, AfterViewInit {
                     return;
                 }
 
+                // Put a hard-stop on modifying magic copy statuses.
+                // We can get here by applying a copy template.
+                if (field === 'status' && (
+                    this.volcopy.copyStatIsMagic(copy.status()) ||
+                    this.volcopy.copyStatIsMagic(value))) {
+                    return;
+                }
+
                 copy[field](value);
                 copy.ischanged(true);
             });