From: Jeff Godin <jgodin@tadl.org>
Date: Fri, 28 Jan 2022 22:54:38 +0000 (-0500)
Subject: Avoid fleshing standing penalty org unit children
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c4489e045238388ff9f66d2b7e254a5f79c8b186;p=evergreen%2Ftadl.git

Avoid fleshing standing penalty org unit children

When fleshing the org unit on standing penalties, exclude child org
units. We don't need them, and they can cause issues when your
standing penalty has a Depth of "Everywhere": you end up with a full
copy of the org unit tree, and you will include this when editing
and saving the user.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
---

diff --git a/Open-ILS/web/js/ui/default/staff/services/patron_search.js b/Open-ILS/web/js/ui/default/staff/services/patron_search.js
index 136fcdc031..d2ebe6c3fa 100644
--- a/Open-ILS/web/js/ui/default/staff/services/patron_search.js
+++ b/Open-ILS/web/js/ui/default/staff/services/patron_search.js
@@ -259,7 +259,10 @@ function($q , $timeout , $location , egCore,  egUser , egConfirmDialog , $locale
             user.standing_penalties(),
             function(penalty) {
                 if (!angular.isObject(penalty.org_unit()))
-                    penalty.org_unit(egCore.org.get(penalty.org_unit()));
+                    // clone the org unit IDL object and set children to an empty array
+                    org_unit = egCore.idl.Clone(egCore.org.get(penalty.org_unit()));
+                    org_unit.children([])
+                    penalty.org_unit(org_unit);
             }
         );