From: kenstir <kenstir@gmail.com>
Date: Sat, 2 Nov 2013 23:03:45 +0000 (-0400)
Subject: Slightly better tracing of OSRF methods, and a better comment.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c49818101e01680a24da06332be9d7b322df14df;p=working%2FEvergreen.git

Slightly better tracing of OSRF methods, and a better comment.
---

diff --git a/Open-ILS/src/Android/src/org/evergreen/android/globals/Utils.java b/Open-ILS/src/Android/src/org/evergreen/android/globals/Utils.java
index 214059a38b..e6edc28fc5 100644
--- a/Open-ILS/src/Android/src/org/evergreen/android/globals/Utils.java
+++ b/Open-ILS/src/Android/src/org/evergreen/android/globals/Utils.java
@@ -160,8 +160,8 @@ public class Utils {
     public static boolean checkIfNetAddressIsReachable(String url)
             throws NoAccessToServer {
 
-    	// kcxxx: old method of fetching the URL to see if the net is "reachable" was not good.
-    	// For now just check if the url is empty.
+    	// The old method of fetching the URL to see if the net is "reachable" was not good;
+        // it wasted bandwidth and time.  For now just check if the url is empty.
     	return (url.length() > 0);
     }
 
@@ -246,13 +246,11 @@ public class Utils {
         // TODO check params and throw errors
         Method method = new Method(methodName);
 
-        System.out.println("Method :" + methodName + " param:");
+        System.out.println("doRequest Method :" + methodName + ": token :"+authToken+":");
         for (int i = 0; i < params.length; i++) {
             method.addParam(params[i]);
-            System.out.print("Param " + i + ":" + params[i]);
+            System.out.println("Param " + i + ":" + params[i]);
         }
-        // need space
-        System.out.println();
 
         // sync request
         HttpRequest req = new GatewayRequest(conn, service, method).send();
@@ -266,12 +264,12 @@ public class Utils {
             try {
                 textcode = ((Map<String, String>) response).get("textcode");
             } catch (Exception e) {
-                System.err.println("Exception in retreive" + e.getMessage());
+                //System.err.println(e.getMessage());
             }
 
             if (textcode != null) {
                 if (textcode.equals("NO_SESSION")) {
-                    // System.out.println("REQUIRE NEW SESSION");
+                    System.out.println(textcode);
                     throw new SessionNotFoundException();
                 }
 
@@ -297,7 +295,7 @@ public class Utils {
 
         Method method = new Method(methodName);
 
-        System.out.println("Method :" + methodName + ":");
+        System.out.println("doRequest Method :" + methodName + ":");
         for (int i = 0; i < params.length; i++) {
             method.addParam(params[i]);
             System.out.println("Param " + i + ": " + params[i]);
@@ -323,7 +321,7 @@ public class Utils {
     public static Object doRequestSimple(HttpConnection conn, String service,
             String methodName, Object[] params) {
         Method method = new Method(methodName);
-        System.out.println("Method :" + methodName);
+        System.out.println("doRequestSimple Method :" + methodName);
         for (int i = 0; i < params.length; i++) {
             method.addParam(params[i]);
             System.out.println("Param " + i + ":" + params[i]);